Conversation
gustn99
reviewed
Nov 17, 2024
Collaborator
gustn99
left a comment
gustn99
left a comment
There was a problem hiding this comment.
코멘트 확인 후 dev pull 받아서 다시 작업 후 push해 주세요! 제대로 확인하지 않고 머지했다가 이미지 경로 충돌이 일어나길래 revert했습니다 ㅠㅠ 미안해용. . .
| import request, { BaseResponse } from '../../apis/core'; | ||
| import { PostItem as PostItemType, PostsResponse, UserResponse } from './dto'; | ||
| import imageBasic from '../../assets/imageBasic.svg'; | ||
| import imageBasic from '../../assets/defaultProfile.svg'; |
Collaborator
There was a problem hiding this comment.
/assets/default/defaultProfile로 수정되어야 하는데 잘못 수정됐어요!
| import BottomButton from '../../components/BottomButton'; | ||
| import { UserProfileResponse } from './dto'; | ||
| import imageBasic from '../../assets/imageBasic.svg'; | ||
| import imageBasic from '../../assets/defaultProfile.svg'; |
Collaborator
There was a problem hiding this comment.
/assets/default/defaultProfile로 수정되어야 하는데 잘못 수정됐어요!
| import { PostFriendRequestResult } from '../../ResponseDto/PostFriendRequestResult'; | ||
| import HeartSvg from '../../../../assets/default/like-white.svg'; | ||
| import imageBasic from '../../../../assets/imageBasic.svg'; | ||
| import imageBasic from '../../../../assets/defaultProfile.svg'; |
Collaborator
There was a problem hiding this comment.
/assets/default/defaultProfile로 수정되어야 하는데 잘못 수정됐어요!
| import MoreSvg from '../../assets/default/more.svg'; | ||
| import BackSvg from '../../assets/arrow/left.svg'; | ||
| import imageBasic from '../../assets/imageBasic.svg'; | ||
| import imageBasic from '../../assets/defaultProfile.svg'; |
Collaborator
There was a problem hiding this comment.
/assets/default/defaultProfile로 수정되어야 하는데 잘못 수정됐어요!
Collaborator
There was a problem hiding this comment.
요거 사용하는 파일이 있었네요 ㅠㅠ 새 디자인시스템에서 사용하는 아이콘을 default파일에 추가하고, 사용하는 파일에서 경로 수정한 뒤에 삭제해 주세요!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
주요 작업 내용
기타 작업 내용
코드 리뷰 포인트
작업 화면
-없음