Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across workflow configuration, SQL query generation, and pipeline execution. The main highlights include parallelization of pipeline runs, enhanced SQL query logic for better correctness, updates to related tests, and renaming of GitHub Actions job names for clarity.
Pipeline Execution Improvements:
InbPackageandSystemPackageby using Go'ssync.WaitGroup, allowing all table pipelines to run concurrently and improving performance. (pkg/packages/inbrdv/InbPackage.go[1]pkg/packages/srcinb/SystemPackage.go[2]SQL Query Logic Enhancements:
BuildInbRdvSatDeleteQueryto use aNOT EXISTSclause and table aliases, ensuring more accurate deletion logic. (pkg/builder/InbRdv.gopkg/builder/InbRdv.goL56-R63)BuildInbRdvSatInsertQueryto use aLEFT JOINand select only new records, increasing correctness and efficiency. (pkg/builder/InbRdv.gopkg/builder/InbRdv.goL74-R80)Test Updates:
pkg/builder/InbRdv_test.go[1] [2]pkg/pipeline/inbrdv/RdvPipelineBuilder_test.go[3] [4]ScriptTransactionWrapperand its test to include an explicitCOMMIT;statement, ensuring transaction completion. (pkg/builder/Global.go[1]pkg/builder/Global_test.go[2]Workflow Configuration:
buildtobuild-test,build-publish-development,build-publish-main, andgo-test. (.github/workflows/docker_build.yml[1].github/workflows/docker_build_publish_development.yml[2].github/workflows/docker_build_publish_main.yml[3].github/workflows/go_test.yml[4]Minor Codebase Maintenance:
syncpackage where parallelization was implemented. (pkg/packages/inbrdv/InbPackage.go[1]pkg/packages/srcinb/SystemPackage.go[2]