Skip to content

Content-Container#4

Merged
augustoSamu merged 2 commits intomainfrom
content-container
Dec 21, 2023
Merged

Content-Container#4
augustoSamu merged 2 commits intomainfrom
content-container

Conversation

@augustoSamu
Copy link
Collaborator

No description provided.

@ooloo-bot
Copy link
Contributor

I'm still at that stakeholder meeting I mentioned last week 😓 I'll have a look at this PR soon.

Btw: Could you let me take over the "Top Section" task? That would be nice. It looks so much fun. You can start with the "Bottom Section" task while you're waiting for my review. No time to loose 😉

Head back to the course to continue.

Copy link
Contributor

@ooloo-bot ooloo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. I see one tiny problem though because the content container is too wide on small screens.

Check out my change requests. Afterward, continue with the course.


.content {
min-height: calc(100vh - 100px);
width: 720px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set an additional max-width here to make the container responsive and you should be done 😄

@ooloo-bot ooloo-bot mentioned this pull request Dec 21, 2023
@ooloo-bot
Copy link
Contributor

The meeting is finally over but I need a coffee break first ☕☕☕ I'm back in 5 min to review the code changes.

In the meantime head back to the course to update the bottom section PR.

Copy link
Contributor

@ooloo-bot ooloo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉🎉🎉 You can merge the PR now.

Once you merged this PR continue with the course.

@augustoSamu augustoSamu merged commit 5d2dc48 into main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants