fix(updater): set the real Sparkle EdDSA public key (was a placeholder)#6
Merged
Merged
Conversation
0.1.0-beta.1 shipped `SUPublicEDKey` as the literal `REPLACE_WITH_GENERATED_ED25519_PUBLIC_KEY` placeholder, so Sparkle could not decode it at `startUpdater` and showed "无法启动更新程序 / Failed to start updater" on every launch (Release sets `startingUpdater: true`; Debug never starts it, so this only bit Release and was never caught locally). Use the real ed25519 public key — the shared signing key whose private half is the `SPARKLE_EDDSA_PRIVATE_KEY` CI secret; LockIME ships the same `SUPublicEDKey`. Verified: it decodes to exactly 32 bytes, and a Release build embedding it no longer logs "The provided EdDSA key could not be decoded / Fatal updater error" on launch. Note: 0.1.0-beta.1 (and the universal 0.1.0) cannot auto-update to this — their embedded key is broken — so those users must download the next build by hand.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughThe 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
0.1.0-beta.1opened with 「无法启动更新程序 / Failed to start updater」 on every launch. Root cause:Sources/CloseUp/Info.plistshippedSUPublicEDKeyas the literalREPLACE_WITH_GENERATED_ED25519_PUBLIC_KEYplaceholder, so Sparkle could not decode it atstartUpdater.Live Sparkle log from the installed beta.1:
This sets the real ed25519 public key — the shared signing key whose private half is the
SPARKLE_EDDSA_PRIVATE_KEYCI secret; LockIME ships the identicalSUPublicEDKey.Verification
startUpdater);sign_update --verifyof a beta.1 signature against it passes.EdDSA could not be decoded/Fatal updater errorin the Sparkle log (vs. beta.1 which logs both).Out of scope / operational (not in this diff)
Two further one-time release-setup gaps that were also undone (mirrors what LockIME has correct) — handled operationally, not in code:
SPARKLE_EDDSA_PRIVATE_KEYvalue did not sign (both 0.1.0 and beta.1 appcasts shipped withoutsparkle:edSignature) → re-set from the keychain.gh-pages/ root); feed now serves 200.0.1.0-beta.1and the universal0.1.0cannot auto-update to the fix (their embedded key is broken) — those users must download the next build by hand.