fix(skills): drop misleading path from update not-installed error#228
Conversation
The previous not-installed branch shared a throw with the unmanaged- target branch and filled in targetStates[0].installedSkillDirectoryPath as the displayed path. When the skill was absent from every host, that path was just an arbitrary host pick, making the error look as if update only checked one specific agent. Split the branch so the unmanaged case keeps its meaningful path, and introduce errors.skills.update.notInstalled without a host path for the truly not-installed case. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Summary by CodeRabbit
WalkthroughThis PR refines error messaging in the Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
The previous not-installed branch shared a throw with the unmanaged- target branch and filled in targetStates[0].installedSkillDirectoryPath as the displayed path. When the skill was absent from every host, that path was just an arbitrary host pick, making the error look as if update only checked one specific agent.
Split the branch so the unmanaged case keeps its meaningful path, and introduce errors.skills.update.notInstalled without a host path for the truly not-installed case.