Skip to content

feat(skills): add published skill installation from registry#41

Merged
BlackHole1 merged 2 commits into
mainfrom
add-skills-add
Mar 30, 2026
Merged

feat(skills): add published skill installation from registry#41
BlackHole1 merged 2 commits into
mainfrom
add-skills-add

Conversation

@BlackHole1
Copy link
Copy Markdown
Member

Introduce registry-based skill installation alongside the existing bundled oo skill. Users can now install published skills by package name with interactive selection, explicit --skill flags, or --all.

Key changes:

  • Add registry skill source fetching with auth headers
  • Add tarball archive extraction for skill packages
  • Add interactive multi-select prompt for skill picking
  • Add managed skill metadata and path resolution
  • Extend install command with -s/--skill, --all, -y/--yes options
  • Add @clack/core and picocolors dependencies
  • Update CLI docs in both English and Chinese

Introduce registry-based skill installation alongside the existing
bundled `oo` skill. Users can now install published skills by package
name with interactive selection, explicit --skill flags, or --all.

Key changes:
- Add registry skill source fetching with auth headers
- Add tarball archive extraction for skill packages
- Add interactive multi-select prompt for skill picking
- Add managed skill metadata and path resolution
- Extend install command with -s/--skill, --all, -y/--yes options
- Add @clack/core and picocolors dependencies
- Update CLI docs in both English and Chinese

Signed-off-by: Kevin Cui <bh@bugs.cc>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fdcd892e-bf1a-4f05-8f8d-05dd64bb3524

📥 Commits

Reviewing files that changed from the base of the PR and between a60b2f0 and fd31941.

📒 Files selected for processing (2)
  • src/application/commands/skills/managed-skill-paths.test.ts
  • src/application/commands/skills/registry-skill-archive.test.ts

Summary by CodeRabbit

  • New Features

    • Install published registry skills alongside bundled ones.
    • Interactive multi-select prompts for choosing skills.
    • New CLI options: specify package, select skills, install all, and skip confirmation.
    • Skill metadata now records package info plus version.
  • Bug Fixes

    • CLI now uses real process stdin for interactive flows.
  • Documentation

    • Updated command docs and help text for registry-based installs (EN/ZH).
  • Tests

    • Extensive new end-to-end and unit tests covering registry installs, prompts, archives, metadata, and markdown normalization.
  • Chores

    • Added UI/CLI helper dependencies.

Walkthrough

Adds support for installing published Codex skills from an npm-like registry alongside the existing bundled "oo" skill. Introduces registry package fetching, tarball download and extraction, managed-skill path/metadata handling, SKILL.md normalization and guidance injection, interactive TTY prompts for multi-skill selection, and test helpers for simulated interactive I/O. Refactors the skills install CLI to accept a packageName plus --skill, --all, and --yes flags and routes registry installs to new registry-install logic. Includes extensive new tests and documentation updates.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

  • oomol-lab/oo-cli#41: Implements published-registry skill installation and overlapping modules (registry sources, archives, managed-skill helpers) that strongly overlap this PR.
  • oomol-lab/oo-cli#29: Changes skills/install.ts command input schema and defaults; directly related to this PR’s CLI argument refactor.
  • oomol-lab/oo-cli#34: Adds/changes .oo-metadata.json handling and managed-skill metadata logic used by this PR.

Suggested labels

codex

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format with type and scope, and accurately describes the main feature being added: published skill installation from registry.
Description check ✅ Passed The description is well-related to the changeset, providing a clear summary of registry-based skill installation features and key implementation changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Why: Windows CI uses native path separators, so tests that assert
hard-coded POSIX paths fail even though the implementation is correct.

What: Replace literal path expectations with node:path.join in the
managed skill path and archive extraction tests.

How: Keep the runtime code unchanged and make the assertions derive
expected paths through the same platform-aware path helper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant