test: add unit tests and document test quality rules

[BlackHole1]

• Add tests for file-store-utils, completion command, and file cleanup command
• Refactor skills install-progress tests: extract shared translator stub and normalizeOutput helper to reduce duplication
• Add failure summary and spinner interval tick test cases
• Document "DRY in Tests" and "try/finally over try/catch/rethrow" rules in AGENTS.md and CODE_QUALITY_RULES.md

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2df97101-e113-47b9-a86f-d6dcc4802ef1

📥 Commits

Reviewing files that changed from the base of the PR and between 20106b0 and 46896f9.

📒 Files selected for processing (7)

• AGENTS.md
• CODE_QUALITY_RULES.md
• src/adapters/store/file-store-utils.test.ts
• src/application/commands/completion.test.ts
• src/application/commands/file/cleanup.test.ts
• src/application/commands/skills/install-progress.test.ts
• src/application/commands/skills/progress-renderer.test.ts

---

Summary by CodeRabbit

• Documentation

  • Updated development and code quality guidelines with best practices for test setup consolidation and error handling patterns.

• Tests

  • Added comprehensive unit test coverage for file storage utilities, shell completion commands, file cleanup operations, and skill installation and progress reporting features.

Walkthrough

The PR adds comprehensive test coverage for multiple CLI command modules and two documentation files. New test suites are introduced for file-store utilities, completion command, and file cleanup command. Existing progress-reporting tests are refactored to extract shared translator stubs and add test cases for spinner rendering and failure scenarios. Documentation updates to AGENTS.md and CODE_QUALITY_RULES.md provide development guidance on extracting repeated test setup into factory functions and preferring try/finally over try/catch for cleanup patterns.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• test(cli): split monolithic CLI test into per-command modules #22 — Adds per-command CLI test files and extracts shared test helpers (such as those imported from __tests__/helpers.ts), following the same test structure patterns as this PR.
• feat(skills): preselect installed skills and remove deselected ones #48 — Introduces the TerminalProgressRenderer and SkillsInstallProgressReporter spinner behavior that is directly exercised by the new test cases in this PR.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required format <type>(<scope>): <subject> with type 'test' and subject clearly summarizing the main changes (adding unit tests and documenting test quality rules).
Description check	✅ Passed	The description is directly related to the changeset, detailing the addition of new tests, refactoring of existing tests, and documentation of code quality rules across multiple files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}