Skip to content

fix(self-update): remove legacy oo installs across PATH#88

Merged
BlackHole1 merged 1 commit into
mainfrom
remove-all-legacy-oo
Apr 22, 2026
Merged

fix(self-update): remove legacy oo installs across PATH#88
BlackHole1 merged 1 commit into
mainfrom
remove-all-legacy-oo

Conversation

@BlackHole1
Copy link
Copy Markdown
Member

The managed installer should clean up legacy package-manager installs even when they appear after the native executable on PATH.

Continue scanning PATH after native and unknown oo entries so every recognized legacy install is removed. Update the regression test and command docs to match the broader cleanup behavior.

The managed installer should clean up legacy package-manager installs
even when they appear after the native executable on PATH.

Continue scanning PATH after native and unknown oo entries so every
recognized legacy install is removed. Update the regression test and
command docs to match the broader cleanup behavior.

Signed-off-by: Kevin Cui <bh@bugs.cc>
@BlackHole1 BlackHole1 merged commit b750188 into main Apr 22, 2026
4 of 5 checks passed
@BlackHole1 BlackHole1 deleted the remove-all-legacy-oo branch April 22, 2026 05:46
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: badea583-3b38-4e9a-879b-b7640672cf0b

📥 Commits

Reviewing files that changed from the base of the PR and between a357dca and 424c3b7.

📒 Files selected for processing (4)
  • docs/commands.md
  • docs/commands.zh-CN.md
  • src/application/self-update/legacy-installation.test.ts
  • src/application/self-update/legacy-installation.ts

Summary by CodeRabbit

  • Documentation

    • Updated oo install [version] and oo update command documentation in both English and Chinese versions to clarify that legacy global installations are now removed from all locations in PATH, rather than only specific positions.
  • Improvements

    • Enhanced legacy installation cleanup to comprehensively scan all PATH locations for old CLI versions, ensuring more thorough removal of obsolete global package manager installations.

Walkthrough

This PR updates the legacy package manager cleanup behavior during CLI installation and updates. Documentation for both oo install [version] and oo update commands is modified to clarify that the system attempts to remove old global @oomol-lab/oo-cli installations found at any position within PATH, rather than only those appearing before the managed executable. The implementation is updated to continue scanning remaining PATH directories even after encountering native or unknown installation methods. The corresponding test is adjusted to validate this broader PATH scanning approach while maintaining the same expected uninstall command sequence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant