Skip to content

test(skills): derive bundled host error expectation#97

Merged
BlackHole1 merged 1 commit into
mainfrom
improve-test-2
Apr 23, 2026
Merged

test(skills): derive bundled host error expectation#97
BlackHole1 merged 1 commit into
mainfrom
improve-test-2

Conversation

@BlackHole1
Copy link
Copy Markdown
Member

The no-host install test duplicated the bundled host ordering in its expected stderr. Reusing the shared host list keeps the test focused on CLI behavior while leaving the host order asserted in the registry tests.

The no-host install test duplicated the bundled host ordering in its expected stderr. Reusing the shared host list keeps the test focused on CLI behavior while leaving the host order asserted in the registry tests.

Signed-off-by: Kevin Cui <bh@bugs.cc>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f86d6518-e841-450c-b1eb-4d39b92b07d6

📥 Commits

Reviewing files that changed from the base of the PR and between 5d4925a and bdccac0.

📒 Files selected for processing (1)
  • src/application/commands/skills/index.test.ts

Summary by CodeRabbit

  • Tests
    • Updated test assertions for skill host validation to dynamically compute expected values instead of using hardcoded configurations, improving test maintainability.

Walkthrough

This PR updates a test assertion in src/application/commands/skills/index.test.ts that validates error messaging for the "no supported bundled skill host is installed" failure case. The change replaces hardcoded home directory variables with a dynamic computation that maps availableBundledSkillAgentNames through resolveBundledSkillHomeDirectory() to generate the expected list. The resulting comma-separated list is then interpolated into the stderr expectation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title follows the required format (): with 'test' as type and 'skills' as scope, clearly describing the test update to derive bundled host error expectations.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for updating the test to reuse the shared host list instead of duplicating the bundled host ordering.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@BlackHole1 BlackHole1 merged commit 4dd94b1 into main Apr 23, 2026
5 checks passed
@BlackHole1 BlackHole1 deleted the improve-test-2 branch April 23, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant