Skip to content

refactor(skills): check bundled hosts concurrently#98

Merged
BlackHole1 merged 1 commit into
mainfrom
improve-skills-check
Apr 23, 2026
Merged

refactor(skills): check bundled hosts concurrently#98
BlackHole1 merged 1 commit into
mainfrom
improve-skills-check

Conversation

@BlackHole1
Copy link
Copy Markdown
Member

Bundled skill installation now probes host home directories in parallel.

This keeps host order stable while matching the existing list command

pattern and avoiding unnecessary sequential filesystem checks.

Bundled skill installation now probes host home directories in parallel.

This keeps host order stable while matching the existing list command

pattern and avoiding unnecessary sequential filesystem checks.

Signed-off-by: Kevin Cui <bh@bugs.cc>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3722f776-955b-46f1-ace8-c14792f59506

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd94b1 and d9a131a.

📒 Files selected for processing (1)
  • src/application/commands/skills/shared.ts

Summary by CodeRabbit

  • Refactor
    • Improved performance of bundled skill installation resolution through concurrent processing.

Walkthrough

The resolveAvailableBundledSkillHostInstallations function in src/application/commands/skills/shared.ts has been refactored to use concurrent processing instead of sequential iteration. The function now maps available bundled skill agent names to async computations and awaits them collectively using Promise.all, rather than iterating through them in a for loop. For agent home directories that do not exist, the updated logic returns undefined and filters those entries out at the end, while successfully resolved cases construct the same installation object with agent name, canonical directory path, and installed directory path fields. The final result remains an array containing only existing agent homes.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format '(): ' with 'refactor' as type and 'skills' as scope, clearly describing the main change of concurrent host checking.
Description check ✅ Passed The description is directly related to the changeset, explaining that bundled skill installation now probes host directories in parallel while maintaining order and avoiding sequential checks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch improve-skills-check

Comment @coderabbitai help to get the list of available commands and usage tips.

@BlackHole1 BlackHole1 merged commit 0ae1693 into main Apr 23, 2026
5 checks passed
@BlackHole1 BlackHole1 deleted the improve-skills-check branch April 23, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant