Skip to content

Bug in test_helper report name validation. #37

@nathan-at-least

Description

@nathan-at-least

The regular expression used to validate a report's test_helper field on line #129 of oonib/report/handlers.py is ill-specified:

  • The regexp variable dereferenced is a loop index above.
  • The referent will be the last value of the loop index, which depends on the sort order of dict.iteritems which is not specified and may change between versions or runtimes.

This was verified by source code inspection and I haven't performed any tests yet. It's conceivable that regexp just so happens to consistently refer to a regular expression which accepts relevant test spec names, but this would be coincidence.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions