feat: Group experimental measurements by type #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
approved these changes
Dec 17, 2024
Comment on lines
56
to
57
| itemList.size == 1 -> listOf(itemList.first()) | ||
| itemList.size > 1 && itemList.size == measurements.size -> itemList |
Contributor
There was a problem hiding this comment.
What's the difference between these 2 cases? Aren't we just returning the itemList in both?
| itemList.size == 1 -> listOf(itemList.first()) | ||
| itemList.size > 1 && itemList.size == measurements.size -> itemList | ||
| else -> { | ||
| val key = itemList.first().measurement.test |
Contributor
There was a problem hiding this comment.
You can also get the key from above: .flatMap { (key, itemList) ->
|
|
||
| data class State( | ||
| val result: ResultItem?, | ||
| val groupedMeasurements: List<Any>, |
Contributor
There was a problem hiding this comment.
A sealed interface/class is a safer and more developer-friendly way of having 2 different types in a list. With Any you never know what could be inside.
Comment on lines
148
to
153
| var key: Any = item.toString() | ||
| when (item) { | ||
| is ResultViewModel.MeasurementGroup -> key = item.test.name | ||
| is MeasurementWithUrl -> key = item.measurement.idOrThrow.value | ||
| } | ||
| key |
Contributor
There was a problem hiding this comment.
No need for the key variable, just go with:
key = { item ->
when (item) {
is ResultViewModel.MeasurementGroup -> item.test.name
is MeasurementWithUrl -> item.measurement.idOrThrow.value
}
}
| modifier = Modifier.fillMaxWidth().alpha(0.66f).padding(horizontal = 16.dp), | ||
| ) { | ||
| TestName(item.test, item.measurements.first(), modifier = Modifier.weight(1f)) | ||
| IconButton(onClick = { onDropdownToggled() }) { |
Contributor
There was a problem hiding this comment.
It would be nicer if the whole row was clickable to expand/collapse.
sdsantos
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345