chore(iOS): restructure background task #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
requested changes
Jan 28, 2025
| // https://developer.apple.com/documentation/foundation/nsdate/1410206-timeintervalsince | ||
| fun startSingleRun(spec: RunSpecification) { | ||
| val startDateTime = NSDate() | ||
| val differed = CoroutineScope(Dispatchers.Default).async { |
| // End the task if time expires. | ||
| UIApplication.shared.endBackgroundTask(self.backgroundTask) | ||
| self.backgroundTask = UIBackgroundTaskIdentifier.invalid | ||
| cancel() |
Contributor
There was a problem hiding this comment.
Maybe call it onCancel? The first time I read it I thought it was a method to cancel the task, instead of an event callback.
| differed.start() | ||
| }, cancel = { | ||
| differed.cancel() | ||
| Logger.i { "Job cancelled after ${NSDate().timeIntervalSinceDate(startDateTime)} ms" } |
Contributor
There was a problem hiding this comment.
Logger.i will only log as a breadcrumb. This only gets sent if there's an error. Or will we always call line 26 inside the catch when it's aborted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399