Screenshots for test results #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanorbel
requested changes
Feb 11, 2025
...droidInstrumentedTest/kotlin/org/ooni/probe/uitesting/screenshots/AutomateScreenshotsTest.kt
Outdated
Show resolved
Hide resolved
...droidInstrumentedTest/kotlin/org/ooni/probe/uitesting/screenshots/AutomateScreenshotsTest.kt
Outdated
Show resolved
Hide resolved
|
|
||
| clickOnText("Websites") | ||
|
|
||
| wait(10.seconds) { onNodeWithText("https://z-lib.org/").isDisplayed() } |
Member
There was a problem hiding this comment.
We can use a composite statement here and check if multiple UI elements are displayed. This would help avoid the need to do Thread.sleep()
Contributor
Author
There was a problem hiding this comment.
This was the screenshot that was coming up blank. Only the sleep fixed it.
aanorbel
requested changes
Feb 11, 2025
Member
aanorbel
left a comment
aanorbel
left a comment
There was a problem hiding this comment.
still having multiple errors running locally and missing imports
Comment on lines
-9
to
-18
| import ooniprobe.composeapp.generated.resources.Dashboard_Progress_UpdateLink_Label | ||
| import ooniprobe.composeapp.generated.resources.Modal_EnableNotifications_Title | ||
| import ooniprobe.composeapp.generated.resources.OONIRun_Run | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_AutomatedTesting_Title | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_Crash_Title | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_DefaultSettings_Button_Go | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_DefaultSettings_Title | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_PopQuiz_True | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_ThingsToKnow_Button | ||
| import ooniprobe.composeapp.generated.resources.Onboarding_ThingsToKnow_Title |
...droidInstrumentedTest/kotlin/org/ooni/probe/uitesting/screenshots/AutomateScreenshotsTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate screenshots for Test Results
Closes #449