Fix Android isBatteryCharging and auto-run notifications #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RunBackgroundTask.ktchanges fix the auto-run notification not updating.I updated the
checkBatteryChargingcode to the code provided by the reference. But please test it too @aanorbel.I also improved the descriptor update notification and notification channel. That introduced a new string for translations.
@agrabeli Can you approve the new "Link Updates" string we added? It's only visible through app settings. It's to distinguish notifications from our background tests, and when we're just updating the Links (once per day). Users can pick whether to see or not those notifications. The channel name needs to be short.