OONI Run v2: Details not implemented in Link Updated flow

[jbonisteel]

Expected Results:

• When a Run v2 link is updated by the admin, the UI on the app should confirm to what we have outlined in the Figma file

Actual Results - there are a few things missing:

• In the figma file there is a red 'updated' warning on the test detail view, that was not implemented
• Also in the figma file, when a Run link needs to be updated, there should be the same red 'updated' warning on the dashboard - that did not appear
• I also don't see the previous revisions that were implemented in the figma file

[aanorbel]

@jbonisteel , should the red warning not say Update available when the descriptor needs an update and if we need to show Updated it should not be a warning but a green/success chip?

[jbonisteel]

@aanorbel I like you suggestion, but am unconcerned that 'Update available' would be long - let's implement what is in the Figma files for now.

[aanorbel]

@jbonisteel , to clarify, what is the condition of the updated chip. The language in the design an this issue doesn't make it clear to me if it is intended to show that

• The descriptor needs to be updated.
• The descriptor was recently updated.

With each case, the logic is very different.

[hellais]

Yes I agree with @aanorbel it should say "Update available" since the link hasn't actually been updated yet.

I also agree it should maybe not be red, since it's not a warning, it's more to say "Hey there is an update to this link, you should check if it looks good and if so update it".

Edit: we looked more into this and it seems like the Update available view only appears when you tap on the X button. In that case it's probably appropriate to have it be red, but we should shorten the label in the dashboard view to say "Update" since "update available" might not fit here.

[jbonisteel]

I just reviewed this again. Looking good, but a small nit-pik:

The alignment of the red 'updated' banner looks off at the top of the screen. Likely not a release blocker

[jbonisteel]

Adding a screen recording of the crash

screen-20240719-080446.mp4

[jbonisteel]

The crash has been fixed