Resolves #1220, Implement File.read in Nashorn#1222
Merged
elia merged 2 commits intoopal:masterfrom Dec 6, 2015
Merged
Conversation
stdlib/nashorn/file.rb
Outdated
Member
There was a problem hiding this comment.
Can you remove the < IO part just to avoid conflicts if the superclass of File ever changes?
elia
added a commit
that referenced
this pull request
Dec 6, 2015
Resolves #1220, Implement File.read in Nashorn
Member
|
Thanks, I think we should tweak the pattern a bit and maybe move the platform detection to |
Member
Author
|
You are welcome 😄
What is the drawback ? A bigger Javascript file ? |
hmdne
pushed a commit
to hmdne/opal
that referenced
this pull request
Jan 27, 2024
Bumps [pug](https://github.com/pugjs/pug) from 3.0.0 to 3.0.2. - [Release notes](https://github.com/pugjs/pug/releases) - [Commits](https://github.com/pugjs/pug/compare/pug@3.0.0...pug@3.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.