Merged
Conversation
added 2 commits
May 12, 2015 02:36
…lock is passed but not when an Enumerable#to_a is called.
Replaced self.dup with `self.slice()` Moved var declarations to the top to reflect hoisting
Contributor
|
Excellent, @kaiwren! But one last small problem: the variable Side note: We really should find a way to integrate JSLint/JSHint into the build/test process for Opal at some point. |
Member
|
@vais I can see it added to allow failure in travis with something like this: rake dist
jslint build/*I don't expect it to be green for a while… |
Member
|
probably this is a good option: https://github.com/stereobooster/jshintrb |
Member
Contributor
|
@kaiwren I'd like to merge this PR, could you do another push with |
Contributor
Author
|
Apologies, fixed. |
Contributor
|
🍻 |
elia
added a commit
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.