fix: fix variable preventing notifications from implicitly being marked as read

[staceybeard]

By submitting this merge request, I confirm the following:

• The merge request title follows the conventional commits convention.

Changes

When the sqlInterface was refactored to ECMAScript module syntax, the function updateReadStatus was changed to take as input a requestObject instead of individual parameters. However, two references to the old parameter userId were left behind, breaking implicit reading of notifications.

Replaced references to this parameter with requestObject.UserID to fix the query execution.

Dependencies

• Listener: Bug introduced in refactor: restructure the project with ECMAScript module syntax #444

Issues

Closes opalmedapps/opal-app#1461

[mschoettle]

LGTM!

I assume that userId shows up in an IDE as undeclared. If we were to enable eslint to detect just this would we be able to find cases like this automatically?

[staceybeard]

LGTM!

I assume that userId shows up in an IDE as undeclared. If we were to enable eslint to detect just this would we be able to find cases like this automatically?

Thanks! Yes, the IDE shows it, but there are a lot of false positives due to attributes in the request objects. They would probably come up via eslint too.