This repository was archived by the owner on Jun 12, 2018. It is now read-only.
fix(hapi): do not overwrite tags of events#147
Merged
watson merged 2 commits intoopbeat:masterfrom May 18, 2017
Merged
Conversation
Contributor
Author
|
Build failing on node 7 |
Contributor
Author
|
@watson sorry to ping but this breaks our logging more than I thought, could you take a look? 👼 |
Contributor
|
@AdriVanHoudt yes, the 7.x failures are a "bug" in the latest version of Node 7. It will be fixed in the next release which is being released shortly |
Contributor
|
@AdriVanHoudt Thanks 😃 It's published in version 4.13.2 |
Contributor
Author
|
Awesome thanks! 💪 |
watson
added a commit
that referenced
this pull request
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused bugs (tags being [object Object]) in other log handlers that log to other places. 😱
This change will cause the tags in the extra field in to be
tags ['error', 'email']instead of
tags {'error': True, 'email': True}which seems like an overall improvement 👌