Mautrix signal #35
Merged
Mautrix signal #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove useless "By()" calls
Say my name... s/Heisenberg/Heisenbridge/ You're goddamn right !
Currently this section only tracks the bridge's IP address. This value is needed in the mautrix-signal config file.
It is composed of: * mautrix-signal: Deployement, Service, 1 PVC to host the bridge's data, 1 PVC to host the SQLite database file, and a ConfigMap to provide the input config.yaml * signald: Deployment and PVC As for the configuration of Synapse (homeserver.yaml), and Heisenbridge (heisenbridge.yaml), the user can provide its own config.yaml for mautrix-signal. In that case, a copy of the user-provided ConfigMap is created. In the copied object, some configuration options are overwritten. The user-provided ConfigMap is not modified. Alternatively, if the user doesn't provide a ConfigMap, a default config.yaml is used for configuring the mautrix-signal bridge. The controller also takes care of updating the configuration of Synapse so that it is aware of the newly deployed bridge (added as an appservice in homeserver.yaml)
Ensure the log_config and signing_key_path are configured according to the Homeserver ServerName value provided by the user.
The bridge requires the anyuid scc as it must run with UID & GID 1337.
acmenezes
reviewed
Jun 23, 2022
acmenezes
reviewed
Jun 23, 2022
acmenezes
left a comment
acmenezes
left a comment
There was a problem hiding this comment.
Generally speaking, pretty solid code. Nothing really big to add as a comment except for the permissions that are too wide both in RBAC and Linux users in containers. If you don't want to touch it up. Go for it and merge. Looking pretty good.
This commit creates a new test_utils.go file to group common functions for tests.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: acmenezes, mgoerens The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a new feature: the ability to deploy the mautrix-signal bridge alongside Synapse.
"mautrix-signal" is a Matrix bridge for Signal. It is optional to run this bridge. Its options lives next to the Heisenbridge (IRC bridge) under
Synapse.Spec.Bridges