fix: derive AllWorkloadNames from registry instead of hardcoding#40
Merged
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
mrhillsman
force-pushed
the
fix/derive-workload-names-from-registry
branch
2 times, most recently
from
830ff29 to
3440ad3
Compare
AllWorkloadNames is now a function that returns DefaultRegistry().List() instead of a hardcoded slice. This ensures workload names are always derived from the actual registry, preventing silent exclusion of newly added workloads. Changes: - Convert AllWorkloadNames from var to func in registry.go - Update all usages to call AllWorkloadNames() - Add test to verify AllWorkloadNames() matches DefaultRegistry().List() Fixes #6 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
fix/derive-workload-names-from-registry
branch
from
3440ad3 to
030476b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AllWorkloadNames is now a function that returns DefaultRegistry().List() instead of a hardcoded slice. This ensures workload names are always derived from the actual registry, preventing silent exclusion of newly added workloads.
Changes:
Fixes #6