fix: add Roles() method to MultiVMWorkload interface#48
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
The orchestrator previously hardcoded roles as ["server", "client"] which would silently break multi-VM workloads using different role names. Changes: - Add Roles() []string method to MultiVMWorkload interface - Implement Roles() in NetworkWorkload returning ["server", "client"] - Update orchestrator to call multiVM.Roles() instead of hardcoding - Add unit test to verify Roles() returns expected values Fixes #4 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
fix/multi-vm-workload-roles
branch
from
88c2b44 to
4d83885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The orchestrator previously hardcoded roles as ["server", "client"] which would silently break multi-VM workloads using different role names.
Changes:
Fixes #4