[DOC] Fix document issue #1395
Merged
[DOC] Fix document issue #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiguiw
requested review from
XinyaoWa,
letonghan and
lvliang-intel
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
The number of built docker images is incorrect in CodeGen and ChatQnA REAME.md. Fix issue opea-project#1383 Signed-off-by: Wang, Xigui <xigui.wang@intel.com>
NeoZhangJianyu
approved these changes
Jan 16, 2025
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Mar 4, 2025
Signed-off-by: Wang, Xigui <xigui.wang@intel.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
letonghan
pushed a commit
that referenced
this pull request
Sep 17, 2025
* Instructions using openAI style remote endpoint Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Readme for openai style remote endpoint Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Adding remote textgen service, openai standard Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Code and test for openai style endpoint Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Clarified instructions in README_endpoint_openai.md Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Commented out stop_containers at beginning. Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Add a little code comment for clarity Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix the curl to text gen service s it doesn't need a key Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Modify unit test since vLLM 0.8.3 changed docker files path Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Cleaned up comments Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Adding a suitable vllm block-size for cpu Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Allow text-generation service.py to work with openai compatible endpoints that do not allow null or None as input e.g. openrouter Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Updated README fixed small typos and make it easier to paste example curl Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated test_llms_textgen_endpoit_openai.sh Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Uncomment build_vllm_image Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Fix the WORKPATH Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Generalize OpeaTextGenService to be usable with other open ai compatible endpoints in addition to tgi and vllm Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Add testing for both openai api chat completion and regular completions Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Generalize the OpeaTextGenService so it can be used for openai like APIs beyond TGI and vLLM eg openrouter.ai Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added logging import Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Go back to relative path for ChatTemplate Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Fixed two argument error and omit language arg for chatcompletions Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix unit tests Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert and simplify Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix stri interp bug Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * More logger fstring to fix Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert to old unit test. Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * To fix the test test_llms_text-generation_service_vllm_on_intel_hpu.sh The path of docker files used to build image from vllm-fork changed recently Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Pin supported version of transformers 4.45.2 for gaudi 1.20.1 and use separate requirements_hpu.txt for building Dockerfile.intel_hpu_phi4 Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Update llama-index-core requirements to align with recent PRs Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Revert back path to Dockerfile.hpu Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Pin version range of numpy to be compatible with transformers and torch Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added logging if vllm-gaudi-server fails Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Seeing if omitting transformers and numpy will help hpu CI unit tests by not overwriting dependencies from the Gaudi container Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Add more logging ot text-generation_service_vllm_on_intel_hpu and pin transformers and numpy Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Refactored ALLOWED_CHATCOMPLETION_ARGS and ALLOWED_COMPLETION_ARGS Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Trying depedencies that are known to work with Gaudi 1.20.1 Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * Revert back to main hpu test and text gen hpu Dockerfile Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: xiguiw <111278656+xiguiw@users.noreply.github.com> Co-authored-by: Liang Lv <liang1.lv@intel.com> Co-authored-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com> Co-authored-by: Rachel R <rroumeliotis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of built docker images is incorrect in
CodeGen and ChatQnA REAME.md.
Fix issue #1383
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
#1383
Type of change
Dependencies
No
Tests
No