Skip to content

Add opea/vllm-rocm README.md link in docker_images_list.md#1925

Merged
chensuyue merged 5 commits into
mainfrom
update
May 13, 2025
Merged

Add opea/vllm-rocm README.md link in docker_images_list.md#1925
chensuyue merged 5 commits into
mainfrom
update

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented May 9, 2025

Description

Add opea/vllm-rocm README.md link

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings May 9, 2025 08:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the docker_images_list.md file to add a README.md link for the opea/vllm-rocm Docker image, providing additional documentation for users.

  • Replaces an empty README link with a new URL for opea/vllm-rocm.
  • Updates the table row to include the new link that points to the relevant README section.
Comments suppressed due to low confidence (1)

docker_images_list.md:114

  • [nitpick] The newly added README link differs from the pattern used in other entries (which typically point directly to a README.md file). Please verify that linking to a repository section via a tree URL is intentional.
| [opea/vllm-rocm](https://hub.docker.com/r/opea/vllm-rocm)                                                           | [Link](https://github.com/opea-project/GenAIComps/blob/main/comps/third_parties/vllm/src/Dockerfile.amd_gpu)          | Deploying and servicing VLLM models on AMD Rocm based on VLLM project                                                                                                                        | [Link](https://github.com/opea-project/GenAIComps/tree/main/comps/third_parties/vllm#24-vllm-with-rocm-on-amd-gpu)

Comment thread docker_images_list.md Outdated
@ZePan110 ZePan110 added the WIP label May 9, 2025
@ZePan110 ZePan110 removed the WIP label May 13, 2025
@chensuyue chensuyue merged commit a0bdf8e into main May 13, 2025
15 checks passed
@chensuyue chensuyue deleted the update branch May 13, 2025 05:34
letonghan pushed a commit that referenced this pull request Sep 17, 2025
…1925)

* Support Redis for ChatHistory, Feedback Management, Prompt Registry

Signed-off-by: Yi Yao <yi.a.yao@intel.com>

---------

Signed-off-by: Yi Yao <yi.a.yao@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
…ect#1925)

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants