Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CodeTrans CI by enabling tests with the latest base image and improving log readability in the GHA outputs.
- Adds build arguments (IMAGE_REPO and BASE_TAG) to pass registry and tag values.
- Introduces an "extends" property to reuse configuration from the "codetrans" service.
Files not reviewed (7)
- CodeTrans/Dockerfile: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_rocm.sh: Language not supported
- CodeTrans/tests/test_compose_on_xeon.sh: Language not supported
- CodeTrans/tests/test_compose_tgi_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_tgi_on_xeon.sh: Language not supported
- CodeTrans/tests/test_compose_vllm_on_rocm.sh: Language not supported
Comments suppressed due to low confidence (2)
CodeTrans/docker_image_build/build.yaml:8
- Ensure that the new build argument 'IMAGE_REPO' is actively used in the Dockerfile so that the intended base image from ${REGISTRY} is correctly applied during the build.
IMAGE_REPO: ${REGISTRY}
CodeTrans/docker_image_build/build.yaml:50
- Confirm that the 'extends' property is supported in this YAML configuration to correctly inherit properties from the 'codetrans' service and maintain expected behavior.
extends: codetrans
Signed-off-by: chensuyue <suyue.chen@intel.com>
lvliang-intel
approved these changes
May 13, 2025
ZePan110
approved these changes
May 13, 2025
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
… GHA outputs. (opea-project#1929) Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.