Skip to content

Conversation

@ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented May 12, 2025

Description

Fix input check for helm test workflow

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIExamples/actions/runs/14966494611 test passed

Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings May 12, 2025 07:35
@ZePan110 ZePan110 requested a review from chensuyue as a code owner May 12, 2025 07:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the input validation for the helm test workflow by updating the regex pattern used in the validation.

  • Updated regex to allow alphanumeric characters (both uppercase and lowercase) instead of just alphabetic characters.
  • The error message, however, still suggests that only lowercase alphanumeric characters are allowed.
Comments suppressed due to low confidence (1)

.github/workflows/_helm-e2e.yml:140

  • The regex pattern now allows uppercase characters, but the error message states that only lowercase alphanumeric characters are allowed. Consider updating the error message or modifying the regex to only allow lowercase characters to maintain consistency.
if [[ ! "$example" =~ ^[a-zA-Z0-9]{1,20}$ ]] || [[ "$example" =~ \\.\." ]] || [[ "$example" == -* || "$example" == *- ]]; then

@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@xiguiw xiguiw merged commit 99f2f94 into main May 12, 2025
23 checks passed
@xiguiw xiguiw deleted the fix branch May 12, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants