-
Notifications
You must be signed in to change notification settings - Fork 88
Add DocIndexRetriever doc #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hao Ruan <hao.ruan@intel.com> Signed-off-by: LiuWeijie <weijie.liu@intel.com>
Collaborator
|
[Remind] @mkbhanda @lkk12014402 could you please help to review the PR? |
lkk12014402
reviewed
Mar 24, 2025
lkk12014402
reviewed
Mar 24, 2025
Collaborator
|
@haoruan Thank you a lot for contribution, please help to resolve the review comments |
Contributor
Author
|
sure, thanks for the review |
fix format of list
add DocIndexRetriever into tree
yinghu5
approved these changes
Apr 3, 2025
Collaborator
yinghu5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Contributor
|
@yinghu5 @mkbhanda @chensuyue if no blockers can you please merge |
lkk12014402
approved these changes
Apr 4, 2025
preethivenkatesh
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guide and deployment documents for DocIndexRetriever sample
Fixes #154