Skip to content

Conversation

@haoruan
Copy link
Contributor

@haoruan haoruan commented Mar 7, 2025

Add guide and deployment documents for DocIndexRetriever sample

Fixes #154

Co-authored-by: Hao Ruan <hao.ruan@intel.com>
Signed-off-by: LiuWeijie <weijie.liu@intel.com>
@yinghu5 yinghu5 requested a review from lkk12014402 March 24, 2025 05:08
@yinghu5
Copy link
Collaborator

yinghu5 commented Mar 24, 2025

[Remind] @mkbhanda @lkk12014402 could you please help to review the PR?

@yinghu5 yinghu5 added the A2 ready to fix label Mar 24, 2025
@yinghu5
Copy link
Collaborator

yinghu5 commented Mar 25, 2025

@haoruan Thank you a lot for contribution, please help to resolve the review comments

@haoruan
Copy link
Contributor Author

haoruan commented Mar 25, 2025

sure, thanks for the review

@yinghu5 yinghu5 self-requested a review April 3, 2025 03:24
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@srinarayan-srikanthan
Copy link
Contributor

@yinghu5 @mkbhanda @chensuyue if no blockers can you please merge

@yinghu5 yinghu5 merged commit f49724b into opea-project:main Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 ready to fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DocIndexRetriever Sample Guide Needs to be written

7 participants