Skip to content

bump partmc (switching back to master branch)#483

Merged
slayoo merged 4 commits intoopen-atmos:mainfrom
slayoo:bump_partmc
Apr 1, 2026
Merged

bump partmc (switching back to master branch)#483
slayoo merged 4 commits intoopen-atmos:mainfrom
slayoo:bump_partmc

Conversation

@slayoo
Copy link
Copy Markdown
Member

@slayoo slayoo commented Mar 31, 2026

No description provided.

@slayoo
Copy link
Copy Markdown
Member Author

slayoo commented Mar 31, 2026

@jcurtis2, @tangwhiap, here's a PR bumping PyPartMC's partmc submodule to the current master branch of PartMC, which now includes the merged freezing branch

@slayoo
Copy link
Copy Markdown
Member Author

slayoo commented Mar 31, 2026

actually, we have a test failure:

    @pytest.mark.parametrize("scheme", ["ABIFM", "singular", "const"])
    def test_run_part_do_freezing(common_args, tmp_path, scheme):
        filename = tmp_path / "test"
        env_state = ppmc.EnvState(ENV_STATE_CTOR_ARG_HIGH_RH)
        aero_data = ppmc.AeroData(AERO_DATA_CTOR_ARG_FREEZING)
        aero_dist = ppmc.AeroDist(aero_data, AERO_DIST_CTOR_ARG_FREEZING)
        aero_state = ppmc.AeroState(aero_data, *AERO_STATE_CTOR_ARG_MINIMAL)
        scenario_ctor_arg = copy.deepcopy(SCENARIO_CTOR_ARG_MINIMAL)
        scenario_ctor_arg["temp_profile"][0]["time"] = [0, 900]
        scenario_ctor_arg["temp_profile"][1]["temp"] = [263.0, 243.0]
        args = list(common_args)
        args[0] = ppmc.Scenario(args[4], aero_data, scenario_ctor_arg)
        args[1] = env_state
        args[0].init_env_state(env_state, 0.0)
        args[2] = aero_data
        args[3] = aero_state
        if scheme == "const":
            args[6] = ppmc.RunPartOpt(
                {
                    **RUN_PART_OPT_CTOR_ARG_SIMULATION,
                    "output_prefix": str(filename),
                    "t_max": 3600,
                    "do_immersion_freezing": True,
                    "immersion_freezing_scheme": scheme,
                    "freezing_rate": -1e-4,
                }
            )
        else:
            args[6] = ppmc.RunPartOpt(
                {
                    **RUN_PART_OPT_CTOR_ARG_SIMULATION,
                    "output_prefix": str(filename),
                    "t_max": 3600,
                    "do_immersion_freezing": True,
                    "immersion_freezing_scheme": scheme,
                }
            )
        aero_state.dist_sample(aero_dist, 1.0, 0.0, False, False)
        ppmc.run_part(*args)
    
>       assert aero_state.frozen_fraction > 0.0
E       assert 0.0 > 0.0

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.92%. Comparing base (a986cf5) to head (30da63d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          56       56           
  Lines        2564     2564           
  Branches      144      144           
=======================================
  Hits         2357     2357           
  Misses        132      132           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Copy Markdown
Member Author

slayoo commented Apr 1, 2026

thanks @jcurtis2 for addressing these issue

@slayoo slayoo merged commit 42ec6d4 into open-atmos:main Apr 1, 2026
34 checks passed
@slayoo slayoo deleted the bump_partmc branch April 1, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants