replace "dry radius larger than critical radius" error with setting of r_wet[i]=r_dry[i] #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f r_wet[i]=r_dry[i]
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 76.13% 76.13%
=======================================
Files 269 269
Lines 6801 6801
=======================================
Hits 5178 5178
Misses 1623 1623
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
should we merge this to support https://github.com/atmos-cloud-sim-uj/PySDM-examples/pull/171? |
Member
Author
|
merging + added an issue to add a test covering this logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.