-
Notifications
You must be signed in to change notification settings - Fork 82
move registration feature gates to api, can be used by registration-o… #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move registration feature gates to api, can be used by registration-o… #162
Conversation
|
@qiujian16 As we discussed in registration-operator pr 230 |
qiujian16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm, could we just define the feature name or feature spec in api? I do not think we should have init here, this could be messy when others import api given feature is a global var.
f2c3fb1 to
1fe5b46
Compare
@qiujian16 I have delete |
|
thanks, one more nit thing. How about we have a separate package like |
…perator Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com>
1fe5b46 to
4048eee
Compare
@qiujian16 Yes, I have changed. Plz review again, thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivan-cai, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
move registration feature gates to api, can be used by registration-operator for check input feature gates if valid.
Signed-off-by: ivan-cai caijing.cai@alibaba-inc.com