Skip to content

Conversation

@ivan-cai
Copy link
Contributor

@ivan-cai ivan-cai commented Jun 8, 2022

move registration feature gates to api, can be used by registration-operator for check input feature gates if valid.

Signed-off-by: ivan-cai caijing.cai@alibaba-inc.com

@openshift-ci openshift-ci bot requested review from mdelder and qiujian16 June 8, 2022 02:34
@ivan-cai
Copy link
Contributor Author

ivan-cai commented Jun 8, 2022

@qiujian16 As we discussed in registration-operator pr 230

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, could we just define the feature name or feature spec in api? I do not think we should have init here, this could be messy when others import api given feature is a global var.

@ivan-cai ivan-cai force-pushed the registration_featuregates_to_api branch 3 times, most recently from f2c3fb1 to 1fe5b46 Compare June 8, 2022 03:06
@ivan-cai
Copy link
Contributor Author

ivan-cai commented Jun 8, 2022

hrm, could we just define the feature name or feature spec in api? I do not think we should have init here, this could be messy when others import api given feature is a global var.

@qiujian16 I have delete init() and DefaultSpokeMutableFeatureGate & DefaultHubMutableFeatureGate. Plz review again.

@qiujian16
Copy link
Member

thanks, one more nit thing. How about we have a separate package like feature to put it? I do not think it relates to a certain version of API, right?

…perator

Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com>
@ivan-cai ivan-cai force-pushed the registration_featuregates_to_api branch from 1fe5b46 to 4048eee Compare June 9, 2022 02:19
@ivan-cai
Copy link
Contributor Author

ivan-cai commented Jun 9, 2022

thanks, one more nit thing. How about we have a separate package like feature to put it? I do not think it relates to a certain version of API, right?

@qiujian16 Yes, I have changed. Plz review again, thanks!

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-cai, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants