Add dashboard to lab. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuezhaojun
force-pushed
the
onboard-dashboard
branch
from
820e94c to
3c81f8f
Compare
Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
onboard-dashboard
branch
from
3c81f8f to
d25096b
Compare
Member
Author
|
/assign @qiujian16 |
Member
|
/hold After the community meeting, I am thinking maybe this project should be in the OCM-io org instead of here. WDYT @xuezhaojun ? |
Member
Author
I actually think we can make a lab org from the beginning, from this PR #1 it seems the github action workflows are added globally. The files in .github will increase very quickly and become unmanageable as more project onboard to this repo. But except for .github part, I think for the dashboard currently onboarding to this repo is fine, and we don't need much effort to migrate to the "org" mode in the future. |
Member
Author
|
/assign @qiujian16 |
Member
|
/unhold /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
openshift-merge-bot
bot
merged commit ddcd938
into
open-cluster-management-io:main
2 checks passed
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…ulti-clusters (#1) * init repo setup Signed-off-by: Mike Ng <ming@redhat.com> * fix: authorize GITHUB_TOKEN to commit reviewable diff, override image repo Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * fix: set image.repository properly Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * docs: document CI assumptions Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * fix: overhaul image build process Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * docs: update READMEs Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * fix: update smoketests & tweak devspace accordingly Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: tweaks Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: monorepo tweaks and docs Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * fix: install support-bundle; add serve.sh Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: deduplicate repo list; fix artifact upload Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: compact repo JSON Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: compact repo JSON Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: fix repo root in generate-repo-matrix composite action Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: prefix E2E artifacts w/ github.workspace Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * docs: remove skip for fleetConfig and add param prefixes in values.yaml (#2) Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * chore: add changelog.py Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * chore: fix values.yaml Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: fix E2E devspace config Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: fix E2E devspace config Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * ci: fix changelog.py; PRs must be labelled w/ project name Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * chore: make reviewable w/ latest readme-generator-for-helm Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * fix: revert resource cleanup checks during cleanup; simplify tests; retry if AMW exists (#3) Signed-off-by: Artur Shad Nik <37195151+arturshadnik@users.noreply.github.com> * chore: bump clusteradm and ocm versions to v1.0.0 (#1) * chore: bump clusteradm version to v1.0.0 * chore: bump bundleVersion in values.yaml to v1.0.0 * chore: bump OCM_VERSION adn CLUSTERADM_VERSION in .versions.env * chore: make reviewable Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> --------- Signed-off-by: Mike Ng <ming@redhat.com> Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> Signed-off-by: Artur Shad Nik <37195151+arturshadnik@users.noreply.github.com> Co-authored-by: Mike Ng <ming@redhat.com> Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com> Co-authored-by: Artur Shad Nik <37195151+arturshadnik@users.noreply.github.com> Co-authored-by: Ahmad Malik Ibrahim <ahm.ibr@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test it with: