Skip to content

Conversation

@ahmad-ibra
Copy link
Member

@ahmad-ibra ahmad-ibra commented Nov 20, 2025

Summary by CodeRabbit

Release Notes

  • New Features

    • Extended addon configurations to support both web-based (HTTP/HTTPS) and embedded manifest formats.
  • Bug Fixes

    • Enhanced addon version handling with automatic default versioning when not specified.
    • Refined configuration metadata structure for improved reliability and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Walkthrough

The change modifies the custom-addons Helm template to add a default addon version fallback, remove pre-install/pre-upgrade hook annotations, restructure metadata indentation, and introduce conditional logic to support both HTTP(S) manifest URLs and raw embedded manifests.

Changes

Cohort / File(s) Summary
Addon template updates
fleetconfig-controller/charts/fleetconfig-controller/templates/ocm/custom-addons.yaml
Added default value "v0.0.1" for addon version; removed helm.sh/hook annotation; reorganized metadata structure; introduced conditional block to handle HTTP(S) manifest URLs via manifestsURL or raw manifests via manifestsRaw with pretty-printing; adjusted whitespace and formatting

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review the conditional logic for HTTP(S) vs raw manifest handling to ensure both code paths are correctly formatted
  • Verify metadata indentation changes maintain valid YAML structure and proper nesting
  • Confirm removal of helm hooks does not unintendedly alter deployment timing or initialization behavior
  • Validate the default addon version "v0.0.1" is appropriate for the intended use case

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title accurately reflects the main change: adding a default v0.0.1 version for addons when no version is specified, which is the primary modification in the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmad-ibra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… is specified

Signed-off-by: Ahmad Ibrahim <ahmad.ibrahim@spectrocloud.com>
@ahmad-ibra ahmad-ibra marked this pull request as ready for review November 20, 2025 20:18
@arturshadnik
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 20, 2025
@ahmad-ibra ahmad-ibra changed the title fix: create addon configmap with default v0.0.1 version if no version is specified 🐛: create addon configmap with default v0.0.1 version if no version is specified Nov 20, 2025
@ahmad-ibra ahmad-ibra changed the title 🐛: create addon configmap with default v0.0.1 version if no version is specified 🐛 create addon configmap with default v0.0.1 version if no version is specified Nov 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f31d112 into open-cluster-management-io:main Nov 20, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants