Skip to content

Conversation

@TylerGillson
Copy link
Collaborator

@TylerGillson TylerGillson commented Jul 4, 2025

  • Trim until final / when detecting RELEASE_VERSION. This strips repository names from release tags, e.g. fleetconfig-controller/v0.1.0 -> v0.1.0
  • Set work dir to repository being released during releaseimage workflow so that make images, etc. works

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@openshift-ci openshift-ci bot requested review from mikeshng and qiujian16 July 4, 2025 13:26
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 4, 2025
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from mikeshng July 4, 2025 13:35
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, TylerGillson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 86d7a2c into main Jul 4, 2025
8 checks passed
@TylerGillson TylerGillson deleted the ci/fix-monorepo-release branch July 4, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants