refactoring: make the controller code more readable#406
Merged
Conversation
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
Skarlso
commented
Apr 26, 2024
|
|
||
| // References specifies configuration for the handling of nested component references. | ||
| // +optional | ||
| References ReferencesConfig `json:"references,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
This has been removed because there is no point in having this setting. This will never be false.
However, this is a BREAKING change, so after this has been applied, we'll have to update the demos to remove this setting from the manifests.
Skarlso
force-pushed
the
refactor-controller-code
branch
from
1fb99c4 to
2235f49
Compare
Skarlso
commented
Apr 26, 2024
|
|
||
| var localizations localize.Substitutions | ||
| for _, l := range config.Localization { | ||
| l := l |
Contributor
Author
There was a problem hiding this comment.
Finally after 1.22 these are no longer required.
Skarlso
force-pushed
the
refactor-controller-code
branch
2 times, most recently
from
7decc43 to
530b17a
Compare
Skarlso
force-pushed
the
refactor-controller-code
branch
from
530b17a to
c67787c
Compare
morri-son
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of open-component-model/ocm-project#76
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: