Skip to content

Comments

fix: only update failed progress in case of error#437

Merged
Skarlso merged 1 commit intomainfrom
remove-redundant-status
May 29, 2024
Merged

fix: only update failed progress in case of error#437
Skarlso merged 1 commit intomainfrom
remove-redundant-status

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented May 28, 2024

Description

Fix #436

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Mend Scan Summary: ❌

Repository: open-component-model/ocm-controller

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 2
LICENSE RISK HIGH 10
RESTRICTED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

@Skarlso Skarlso added this to the 2024-Q2 milestone May 28, 2024
@Skarlso Skarlso self-assigned this May 28, 2024
@Skarlso Skarlso merged commit f0b6712 into main May 29, 2024
@Skarlso Skarlso deleted the remove-redundant-status branch May 29, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔒Closed

Development

Successfully merging this pull request may close these issues.

UpdateStatus is not clever enough to understand requeue was on purpose

1 participant