Skip to content

Comments

doc: add some more information regarding versioning#438

Merged
Skarlso merged 1 commit intomainfrom
clarify-versions
May 29, 2024
Merged

doc: add some more information regarding versioning#438
Skarlso merged 1 commit intomainfrom
clarify-versions

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented May 28, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Skarlso Skarlso added this to the 2024-Q2 milestone May 28, 2024
@Skarlso Skarlso self-assigned this May 28, 2024
@github-actions
Copy link

Mend Scan Summary: ❌

Repository: open-component-model/ocm-controller

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 2
LICENSE RISK HIGH 10
RESTRICTED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

interval: 5m
```

It's possible to leave out the version in which case `latest` is used. But that might cause problems down the line later on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something feels off about suggesting that a version should be specified here.

If I look at my POC set up, I have

  • Repo that defines component does not contain ComponentVersion, Configuration, Localization or FluxDeployer and those resources are not part of the component. ( Meaning none of these resources can e configured or localized )
  • ComponentVersion, Configuration, Localization and FluxDeployer are owned by whomever is managing/operating the k8s clusters.
  • Whomever is managing/operating the cluster is setting up a pipeline of sources ComponentVersion -> Localization -> Configuration -> Localization.
  • Any version filtering is happening with in the ComponentVersion spec. Everything else just accepts the latest thing that makes it through the ComponentVersion filter.

Anyhoo, with such a pipeline you really need FluxDeployer to not specify a chart version. I could perhaps see a an exceptional situation where the cluster managers/operators decide that after version X they want to change how a chart is deployed, but that is really exceptional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you know what chart version you want to deploy before. It won't be just latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔒Closed

Development

Successfully merging this pull request may close these issues.

2 participants