doc: add some more information regarding versioning#438
Merged
Conversation
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
dee0sap
reviewed
May 29, 2024
| interval: 5m | ||
| ``` | ||
|
|
||
| It's possible to leave out the version in which case `latest` is used. But that might cause problems down the line later on. |
Contributor
There was a problem hiding this comment.
Something feels off about suggesting that a version should be specified here.
If I look at my POC set up, I have
- Repo that defines component does not contain ComponentVersion, Configuration, Localization or FluxDeployer and those resources are not part of the component. ( Meaning none of these resources can e configured or localized )
- ComponentVersion, Configuration, Localization and FluxDeployer are owned by whomever is managing/operating the k8s clusters.
- Whomever is managing/operating the cluster is setting up a pipeline of sources ComponentVersion -> Localization -> Configuration -> Localization.
- Any version filtering is happening with in the ComponentVersion spec. Everything else just accepts the latest thing that makes it through the ComponentVersion filter.
Anyhoo, with such a pipeline you really need FluxDeployer to not specify a chart version. I could perhaps see a an exceptional situation where the cluster managers/operators decide that after version X they want to change how a chart is deployed, but that is really exceptional
Contributor
Author
There was a problem hiding this comment.
But you know what chart version you want to deploy before. It won't be just latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: