feat: replace UUID with LearningPathKey #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agrendalath
force-pushed
the
agrendalath/bb-9241-refactor-keys
branch
6 times, most recently
from
27ce2c3 to
41b19ce
Compare
Agrendalath
commented
Mar 31, 2025
7 tasks
Agrendalath
force-pushed
the
agrendalath/bb-9241-refactor-keys
branch
2 times, most recently
from
f20c2ef to
c6587b6
Compare
Agrendalath
commented
Apr 1, 2025
| LearningPath = apps.get_model("learning_paths", "LearningPath") | ||
|
|
||
| for learning_path in LearningPath.objects.all(): | ||
| key_str = f"path-v1:test+test+test+{learning_path.uuid}" |
Member
Author
There was a problem hiding this comment.
This plugin has not been deployed anywhere yet, so this function will only affect dev environments.
pkulkark
reviewed
Apr 2, 2025
learning_paths/keys.py
Outdated
|
|
||
| __slots__ = KEY_FIELDS | ||
|
|
||
| _learing_path_key_regex = re.compile(rf"^{LEARNING_PATH_PATTERN}$") |
Member
Author
pkulkark
reviewed
Apr 2, 2025
Member
pkulkark
left a comment
pkulkark
left a comment
There was a problem hiding this comment.
@Agrendalath The changes look good but when I try to run it on my machine, I get this error during migration:
Applying learning_paths.0007_replace_uuid_with_learningpathkey...Traceback (most recent call last):
File "/openedx/venv/lib/python3.11/site-packages/django/db/backends/utils.py", line 89, in _execute
return self.cursor.execute(sql, params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/openedx/venv/lib/python3.11/site-packages/django/db/backends/mysql/base.py", line 75, in execute
return self.cursor.execute(query, args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/openedx/venv/lib/python3.11/site-packages/MySQLdb/cursors.py", line 179, in execute
res = self._query(mogrified_query)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/openedx/venv/lib/python3.11/site-packages/MySQLdb/cursors.py", line 330, in _query
db.query(q)
File "/openedx/venv/lib/python3.11/site-packages/MySQLdb/connections.py", line 261, in query
_mysql.connection.query(self, query)
MySQLdb.IntegrityError: (1062, "Duplicate entry '' for key 'learning_paths_learningpath.key'")
Member
Author
pkulkark
approved these changes
Apr 3, 2025
Member
pkulkark
left a comment
pkulkark
left a comment
There was a problem hiding this comment.
@Agrendalath LGTM 👍
- I tested this: Verified existing APIs and learning paths are accessible with the new key.
- I read through the code
-
Includes documentationN/A
Agrendalath
force-pushed
the
agrendalath/bb-9241-refactor-keys
branch
from
bd3e216 to
f9f2264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the identifiers of the Learning Paths. Instead of the UUIDs, they will be identified by LearningPathKeys.
Testing instructions
Private-ref: BB-9241