MEI-6680 key error on filtering username #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@xitij2000 can you please review? |
Member
|
@mudassir-hafeez I'm afraid we might not be able to this for the next sprint. We will look into it after mid-april. I hope this is OK? |
Contributor
Author
|
Yup, @xitij2000 thanks for informing! Please take it after mid april. |
Contributor
Author
|
@xitij2000 just a reminder to review. Thanks! |
xitij2000
approved these changes
Apr 22, 2021
Member
xitij2000
left a comment
xitij2000
left a comment
There was a problem hiding this comment.
👍
- I tested this: tested on master devstack
- I read through the code
- [na] I checked for accessibility issues
- [na] Includes documentation
Member
|
@mudassir-hafeez I've tested, approved and merged this and also tagged a release. |
Contributor
Author
|
@xitij2000 thanks for reviewing! |
mudassir-hafeez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://mckinsey.atlassian.net/browse/MEI-6680
Fixed
KeyError: 'student_id'as it raises when we search username through instructor tool.