Skip to content

Add Portuguese (Portugal) translation#329

Closed
MoisesGSalas wants to merge 1 commit intoopen-craft:masterfrom
fccn:pt_pt_translations
Closed

Add Portuguese (Portugal) translation#329
MoisesGSalas wants to merge 1 commit intoopen-craft:masterfrom
fccn:pt_pt_translations

Conversation

@MoisesGSalas
Copy link
Copy Markdown

Description

Add Portuguese of Portugal translations.

@arbrandes
Copy link
Copy Markdown

@MoisesGSalas, many thanks for the contribution! We'll get to reviewing it ASAP!

@samuelallan72
Copy link
Copy Markdown
Member

@arbrandes do we have an internal ticket created to track reviewing this and open-craft/xblock-poll#94 ?

@arbrandes
Copy link
Copy Markdown

@swalladge, no, but I did ask for takers in the forum. A proper review of the translation itself is, AFAIK, limited to either me, @giovannicimolin, @viadanna, or @jvdm, though. Any of you interested?

@jvdm
Copy link
Copy Markdown

jvdm commented Aug 5, 2021

@swalladge and @arbrandes: I can take it.

@arbrandes
Copy link
Copy Markdown

@jvdm, awesome, thanks!

@giovannicimolin
Copy link
Copy Markdown
Contributor

@jvdm I have some CC time this sprint, do you want me to take this up?

@jvdm
Copy link
Copy Markdown

jvdm commented Aug 18, 2021

@giovannicimolin Absolutely, please go ahead.

@giovannicimolin
Copy link
Copy Markdown
Contributor

giovannicimolin commented Aug 19, 2021

@MoisesGSalas Look good! I just need a version bump here to push this forward and create a release. 4.1.14 is ok - we're just pulling a new translation.

@arbrandes Btw, this is now about reviewing the translations, but the translation support and check that it's pulling the correct files. The translations are the approved ones on transifex (https://www.transifex.com/open-edx/xblocks/problem-builder/)

@MoisesGSalas
Copy link
Copy Markdown
Author

@giovannicimolin Done. Seems like we have been getting used to each other this last month.

The tests failed, seems to be due to the new Debian release that happened last week. I will hear you on how to proceed on this.

@giovannicimolin
Copy link
Copy Markdown
Contributor

We're working on it on a related pull request. I'll get back to you once we have news.

@Agrendalath
Copy link
Copy Markdown
Member

I cannot rebase this branch through GitHub, so I'll close it for now. Please reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants