-
Notifications
You must be signed in to change notification settings - Fork 60
fix: parse_xml error during import #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse_xml error during import #458
Conversation
|
Hi @Agrendalath, Can you look into this and merge this for me! before it's deprecated as it's deprecation PR isn't merged yet. |
Agrendalath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please indicate (in the commit message) that this is incompatible with Palm.
tox -e py38-django42fails with:
FAILED problem_builder/v1/tests/test_upgrade.py::TestUpgrade::test_xml_upgrade_1_v1_upgrade_a - TypeError: parse_xml() takes 4 positional arguments but 5 were given
FAILED problem_builder/v1/tests/test_upgrade.py::TestUpgrade::test_xml_upgrade_2_v1_upgrade_b - TypeError: parse_xml() takes 4 positional arguments but 5 were given
e381d58 to
9b04644
Compare
|
@Agrendalath I'll ping you once it's ready. |
9b04644 to
f43f9ab
Compare
|
@Agrendalath I have added details in commit message. Can you run the workflows again now. |
|
@Faraz32123 , the worklogs will not run without changing the os to |
4d42628 to
f43f9ab
Compare
|
@Agrendalath let me create a separate PR for that. |
|
@Agrendalath I have created a simple PR here: #459 to update ubuntu version. But I think maintainers can also approve workflows , I am not sure if you are maintainer of this repo or not. But thanks for assisting me here. |
41e1795 In this commit: - fix parse_xml error that occurs during importing a course that contains problem-builder component or during copying pasting the problem-builder component by removing unused & unsupported positional argument i.e. "id_generator". - upgrade requirements especially "xblock[django]" to version "2.0.0" where this extra argument "id_generator" was removed. - With this requirement upgrade, also dropped support for django 3.2. due to conflicts in dependencies in CI. - ERROR: Cannot install Django<5.0 and >=4.2 and django==3.2.25 because these package versions have conflicting dependencies. - update ubuntu version ro ubuntu-latest. - update codecov actions to v5 in CI. Note: This Change will be incompatible with Palm release of openedx.
f43f9ab to
f833c37
Compare
integration tests are failing with below error, This error comes from xblock-utils package which is already deprecated. So, disabling these tests for now.
______ ERROR collecting problem_builder/tests/integration/test_titles.py _______
ImportError while importing test module '/home/runner/work/problem-builder/problem-builder/problem_builder/tests/integration/test_titles.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
problem_builder/tests/integration/test_titles.py:27: in <module>
from xblockutils.base_test import SeleniumXBlockTest
.tox/integration42/lib/python3.8/site-packages/xblockutils/base_test.py:28: in <module>
from workbench.test.selenium_test import SeleniumTest
E ModuleNotFoundError: No module named 'workbench.test.selenium_test'
|
After first commit, integration42 test still fails with below errors. This error comes from xblock-utils package which is already deprecated. So, disabling these integration workflow for now. Detailed error trace can be seen here. |
|
@Agrendalath Can you look into it now! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 45.08% 45.04% -0.04%
==========================================
Files 40 40
Lines 3309 3303 -6
Branches 463 401 -62
==========================================
- Hits 1492 1488 -4
+ Misses 1769 1768 -1
+ Partials 48 47 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Agrendalath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Faraz32123, just a few final notes.
- bump minor version instead of patch one - remove XBlock[django]==2.0.0 constraint from test.in file as it's already in constraints.txt
797071e to
84352ea
Compare
Agrendalath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the unit tests are passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a

In this PR,
Note: This Change will be incompatible with Palm release of openedx.