Skip to content

Conversation

@Faraz32123
Copy link

No description provided.

@Faraz32123
Copy link
Author

@Agrendalath As you can see CI failures for first commit, what are your suggestions?

@Faraz32123 Faraz32123 marked this pull request as draft June 4, 2025 10:00
@Faraz32123 Faraz32123 force-pushed the feat/update_ubuntu_version branch 10 times, most recently from 7a25aa5 to c57ee62 Compare June 4, 2025 12:01
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.08%. Comparing base (5602b7b) to head (5fb101b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files          40       40           
  Lines        3309     3309           
  Branches      463      463           
=======================================
  Hits         1492     1492           
  Misses       1769     1769           
  Partials       48       48           
Flag Coverage Δ
unittests 45.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Faraz32123 Faraz32123 force-pushed the feat/update_ubuntu_version branch 5 times, most recently from 6a5adb2 to 6f77eee Compare June 4, 2025 13:13
sudo apt-get update
sudo apt-get install -y xvfb
sudo apt-get install -y libxmlsec1-dev ubuntu-restricted-extras xvfb libgtk-3-0 libdbus-glib-1-2
wget https://github.com/mozilla/geckodriver/releases/download/v0.32.2/geckodriver-v0.32.2-linux64.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Faraz32123 , this should already be handled in the Makefile. We don't need this in CI scripts and tox config.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking CI in my fork, It was failing first due to browser related issue and then due to selenium related issue.
I have removed it, yes you are right it's handled in makefile. I was just trying things.

Let me know what to do next if you have some suggestions! Thanks 😀
You can see the current CI failures here: Faraz32123#2
Integration tests are failing!! It will fail with only ubuntu-latest change as well.

@Faraz32123 Faraz32123 force-pushed the feat/update_ubuntu_version branch from d56900e to 6f77eee Compare June 4, 2025 13:43
@Faraz32123 Faraz32123 force-pushed the feat/update_ubuntu_version branch from 6f77eee to 5fb101b Compare June 4, 2025 14:09
@Faraz32123
Copy link
Author

closing this PR in favor of #458.

@Faraz32123 Faraz32123 closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants