[fix] read and write unsigned bytes in SignalPdu

[ngjunsiang]

Fixes #46

[leif81]

Thank-you @ngjunsiang !
Do you think the other 4 lines referenced in the issue still require a change too?

[ngjunsiang]

Thank-you @ngjunsiang ! Do you think the other 4 lines referenced in the issue still require a change too?

I couldn't find the other lines, then suddenly remembered I can browse the repository at the point the comment was made 😅

From the comment, the unaddressed lines are:
3605,3609,3618,3623

Mapping them to the current commit:

3605:
https://github.com/ngjunsiang/open-dis-python/blob/473d63abdc00b05703e5aa3246a2eb6f75239c08/opendis/dis7.py#L3789-L3790

3609:
https://github.com/ngjunsiang/open-dis-python/blob/473d63abdc00b05703e5aa3246a2eb6f75239c08/opendis/dis7.py#L3793-L3794

3618:
https://github.com/ngjunsiang/open-dis-python/blob/473d63abdc00b05703e5aa3246a2eb6f75239c08/opendis/dis7.py#L3800-L3801

3623:
https://github.com/ngjunsiang/open-dis-python/blob/473d63abdc00b05703e5aa3246a2eb6f75239c08/opendis/dis7.py#L3805-L3806

I'll push another commit to address these.

[leif81]

Thanks @ngjunsiang

What do you think about the original comment about line 7141 and 7157?

[ngjunsiang]

According to IEEE1278.1-2012, dataLength and samples should be 16-bit unsigned ints as well. I have pushed the changes.

At this rate I can probably do a search for signed reads/writes to check possible bugs 😂

[ngjunsiang]

At this rate I can probably do a search for signed reads/writes to check possible bugs 😂

A quick search reveals most of the signed read/write methods of the input and output stream class are little-used; where they are used, it is primarily for padding.

[leif81]

Ok then thank-you for checking. In that case I suggest we leave the scope of the changes as is. I'll do a quick review and then merge in a moment