Load and save configuration settings #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleaned up comments - Moved variables to be protected, accessible via get/set methods
- Disable UI elements during acquisition - Fix channelMap indexing - Fix swapping settings during connection
jonnew
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All UI elements are now saved to XML when manually saving a file (
Ctrl + S) or when exiting the GUI normally (this creates a lastConfig.xml). Additionally, these same UI elements are now disabled during acquisition so that no settings can be accidentally changed in a vulnerable state.The following is a list of settings interfaces that are finalized:
Fixes #7
Fixes #40
Added a check for voltage override values when changing headstage selection, prompting the user if they want to keep the voltage or allow the automated voltage discovery algorithm to work.
Fixes #52
Convert all timestamps from ticks to seconds before adding to the GUI buffer.
Fixes #53
Add a port status indicator next to each port label that shows the connection status of that port
Fixes #51