-
Notifications
You must be signed in to change notification settings - Fork 1
Add Neuropixels 1.0e Headstage #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the units.
In different places they might appear as
µV
, uV
or �V
(the latter being a non-ascii code)
Also, since this PR is changing to std::string
objects, which are encoding-agnostic, it would be interesting to know what the GUI drawing methods use, because the "micro" sign is not standard ASCII, and thus it has a different encoding in UTF-8 or ASCII, so using a different encoding from what the GUI uses to print might result on display issues.
Juce::String
hides this, since it uses utf-8 internally by default and has methods to convert between encodings, so this might be a little tricky as care needs to be taken manually. This is probably one of the reasons Juce::String
is still part of the library, as it does offer extended functionality not present on std::string
(unlike ScopedPointer
, which became obsolete with C++11's std::unique_ptr
and other smart pointers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
This PR adds the Neuropixels 1.0e headstage as an available option to be selected in the drop-down menu for headstages.
Fixes #55
Fixes #65 (add labels to differentiate 1.0f and 1.0e headstages)