Mark AxisMap and AxisSign as not browsable #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove PolledBno055 TypeConverter, as it is no longer needed - Fix PolledBno055Dialog title
jonnew
approved these changes
Aug 22, 2025
Member
jonnew
left a comment
jonnew
left a comment
There was a problem hiding this comment.
Looks good. I also confirmed I can manually edit the .bonsai file if I really want to apply a different map or axis inversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our discussions, we came to the conclusion that the
AxisMapandAxisSignvariables should not be browsable in any situation; this is different from the original behavior where they were browsable for the device outside of the context of a headstage.This PR removes the
PolledBno055SingleDeviceFactoryConverteras it is no longer needed, and marks the two properties asBrowsable(false). This removes them from the editor in all instances, which achieves the original goal of hiding these properties in the GUIs.Fixes #314