Refactor Rhs2116 design files #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aacuevas
approved these changes
Nov 3, 2025
Collaborator
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
I don't see any problems.
My only suggestion is that, instead of repeating
var sequence = Trigger.StimulusSequence; on every method, cache this on the Trigger set as a private variable, to avoid so much repetition, since it is something apparently needed everywhere.
- Utilize the main library classes directly instead of passing individual properties to the design library
bparks13
force-pushed
the
refactor-rhs2116-design
branch
from
7eae139 to
8787216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to facilitate #515, as the original implementation of the
Rhs2116design files did not work well with the additions created there. Specifically, when adding a property grid to theRhs2116dialogs, the object that was available was theRhs2116StimulusSequencePair, and not theConfigureRhs2116Trigger.This PR updates the
Rhs2116design files to match the convention of the other design files, where the entire Configure node is passed to the Design library and then individual properties are accessed from there, instead of passing individual properties. By passing the entire configure node, the addition in #515 of a property grid will show the entireConfigureRhs2116Triggerobject in the pane, instead of just the stimulus sequence object.