Add support for NPX 2.0 single-shank probes #552
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #493.
Adding support for single-shank Neuropixels 2.0 probes, with the additional functionality of allowing the user to change the probe type in the GUI.
Note that due to the restructuring of the abstract/concrete classes, in the XML file the name of the property is
ProbeConfigurationfor the quad-shank probe (this is simply the name of the property, and is what all older versions of the files will be named), but for the single-shank probe it is renamed toSingleShankProbeConfiguration. We could keep the same name (ProbeConfiguration) and add the type name in the XML tag (i.e.,xsi:type="onix1:SingleShank"), but this will break backward compatibility, since the deserializer cannot know which concrete type to use for the probe configuration property when loading old workflows. If we want to break compatibility for this, we can inform users that they can add the linexsi:type="onix1:QuadShank"to the ProbeConfiguration properties to let it load, but it seemed easier to maintain backward compatibility.@anjaldoshi We do not have any single-shank probes to test with, could you build this branch and run some recordings with a single-shank probe to make sure it records data correctly?
Fixes #446