-
Notifications
You must be signed in to change notification settings - Fork 98
feat: creating flagd OFREP Cloudflare Worker repo #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new repository, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: Norris <jonathan.norris@dynatrace.com>
e09ac26 to
2d3a667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the new flagd-ofrep-cf-worker repository to the flagd workgroup configuration. My review identifies a minor maintainability issue. For consistency with conventions in this project, I've recommended keeping the repository list sorted alphabetically.
| - flagd-schemas | ||
| - flagd-testbed | ||
| - open-feature-operator | ||
| - flagd-ofrep-cf-worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency and readability, this list of repositories should be kept in alphabetical order. This convention is observed in other parts of the configuration, such as the repos list in config/open-feature/org.yaml. Please move flagd-ofrep-cf-worker to its correct alphabetical position, which would be after flagd and before flagd-schemas.
…ration Signed-off-by: Norris <jonathan.norris@dynatrace.com>
Creating a new experimental repo for a flagd powered Cloudflare Worker using OFREP. Starting this off as an experimental repo to test the rust flagd evaluation engine in a Cloudflare Worker, will likely also benchmark the performance of a JS worker vs rust based worker. We will make it public once we have something working and testable.