Skip to content

Updated dependencies versions and refactored library naming#42

Merged
m-olko merged 4 commits intomainfrom
cleanup
Feb 6, 2026
Merged

Updated dependencies versions and refactored library naming#42
m-olko merged 4 commits intomainfrom
cleanup

Conversation

@m-olko
Copy link
Copy Markdown
Contributor

@m-olko m-olko commented Jan 30, 2026

This PR

  • Updates some dependencies version
  • Renames flagd-schemas to flagd_schemas to match other namings
  • Adds .bazelversion and .bazelrc to fix some errors during building

Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko requested a review from oxddr January 30, 2026 16:46
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @m-olko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the project's build system by updating key Bazel dependencies to their most recent stable versions. It also standardizes the naming of a core module within the Bazel configuration, improving consistency. Furthermore, the introduction of dedicated Bazel configuration files aims to streamline the build process, ensure version compatibility, and mitigate specific build-time issues.

Highlights

  • Dependency Updates: Several Bazel dependencies, including rules_cc, rules_python, abseil-cpp, grpc, protobuf, and nlohmann_json, have been updated to their latest versions to ensure the project uses up-to-date libraries.
  • Naming Refactoring: The flagd-schemas Bazel module and its associated build files and references have been renamed to flagd_schemas to align with consistent naming conventions within the build system.
  • Bazel Configuration: New .bazelversion and .bazelrc files have been added. The .bazelversion specifies the required Bazel version (8.5.1), and .bazelrc includes build flags to resolve potential linker script errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@m-olko m-olko marked this pull request as ready for review January 30, 2026 16:47
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies to newer versions, renames the flagd-schemas library to flagd_schemas for consistency, and adds .bazelrc and .bazelversion files to ensure reproducible and stable builds. The changes are straightforward and improve project maintenance. My review includes a couple of minor suggestions for the newly added configuration files to enhance clarity and adhere to common file formatting conventions.

@@ -0,0 +1,3 @@
# Fixes for weird errors related to linker script
build --copt=-fno-asynchronous-unwind-tables
build --linkopt=-Wl,--gc-sections No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a common convention to end text files with a newline character. Please consider adding one.

@@ -0,0 +1 @@
8.5.1 No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a common convention to end text files with a newline character. Please consider adding one.

Signed-off-by: m-olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko merged commit 50b4ee1 into main Feb 6, 2026
2 checks passed
@m-olko m-olko deleted the cleanup branch February 6, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants