Conversation
Signed-off-by: Marcin Olko <molko@google.com>
Summary of ChangesHello @m-olko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the project's build system by updating key Bazel dependencies to their most recent stable versions. It also standardizes the naming of a core module within the Bazel configuration, improving consistency. Furthermore, the introduction of dedicated Bazel configuration files aims to streamline the build process, ensure version compatibility, and mitigate specific build-time issues. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies to newer versions, renames the flagd-schemas library to flagd_schemas for consistency, and adds .bazelrc and .bazelversion files to ensure reproducible and stable builds. The changes are straightforward and improve project maintenance. My review includes a couple of minor suggestions for the newly added configuration files to enhance clarity and adhere to common file formatting conventions.
| @@ -0,0 +1,3 @@ | |||
| # Fixes for weird errors related to linker script | |||
| build --copt=-fno-asynchronous-unwind-tables | |||
| build --linkopt=-Wl,--gc-sections No newline at end of file | |||
| @@ -0,0 +1 @@ | |||
| 8.5.1 No newline at end of file | |||
Signed-off-by: m-olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
This PR
flagd-schemastoflagd_schemasto match other namings.bazelversionand.bazelrcto fix some errors during building